Add node option
#804
Merged
Add node option
#804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Feb 8, 2024
| @@ -288,6 +282,8 @@ export function execaSync(rawFile, rawArgs, rawOptions) { | |||
| }; | |||
| } | |||
|
|
|||
| const normalizeSyncOptions = (options = {}) => options.node && !options.ipc ? {...options, ipc: false} : options; | |||
There was a problem hiding this comment.
node: true can be used with synchronous methods, but ipc: true cannot.
Therefore, ipc: true is not added when using node: true with synchronous methods.
ehmicky
commented
Feb 8, 2024
| }; | ||
|
|
||
| test('Can pass null to options', testNullOptions, execa); | ||
| test('Can pass null to options - sync', testNullOptions, execaSync); |
There was a problem hiding this comment.
This test was documenting that execa('file', [...args], null) currently does not throw.
This PR breaks this behavior. We could still support passing null, but it feels like this is not something we should support, and it is undocumented.
There was a problem hiding this comment.
Yeah, it should not be supported.
ehmicky
force-pushed
the
node-option
branch
2 times, most recently
from
4bf0902
to
5532b2e
Compare
|
Conflict fixed. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #781.