Fix types of execaSync()
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Mar 29, 2024
index.d.ts
Outdated
| | 'ignore' | ||
| | 'inherit'; | ||
| | 'inherit' | ||
| | IfAsync<IsSync, 'overlapped'>; |
There was a problem hiding this comment.
Note: overlapped currently crashes the process with spawnSync(), instead of just throwing an error, or just behaving like pipe.
I opened a bug in nodejs/node#52265
ehmicky
force-pushed
the
sync-types
branch
5 times, most recently
from
42bf3cd
to
dab6913
Compare
|
Fixed merge conflict. |
ehmicky
force-pushed
the
sync-types
branch
5 times, most recently
from
b05007b
to
d8c1134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the types of
execaSync(), making it clearer that some features are not available with synchronous methods.