Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
error.isMaxBuffer: boolean
. This istrue
when the subprocess failed due to themaxBuffer
option.Figuring out whether the subprocess failed due to the
maxBuffer
option is not completely straightforward otherwise:execa()
fails withMaxBufferError
instances (which Execa does not export)execaSync()
fails witherror.code
ENOBUFS
. However that code is also used for other errors by Node.js.Also, this PR improves the error message when
maxBuffer
is hit. Previously, it just showedmaxBuffer exceeded
. Now, the error message is clearer. Also, it indicates:stdout
,stderr
,stdio[3]
, etc.maxBuffer
value