From db7e73a6f48728072bb908ca585ad79e088fc9f3 Mon Sep 17 00:00:00 2001 From: ehmicky Date: Mon, 20 May 2019 15:44:40 +0200 Subject: [PATCH 1/2] Add TODO comment about `spawned.stdin` bug being fixed in Node 12 --- index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 7a8e3b150..ac229ae9b 100644 --- a/index.js +++ b/index.js @@ -97,7 +97,8 @@ function handleArgs(command, args, options = {}) { } function handleInput(spawned, input) { - // Checking for stdin is workaround for https://github.com/nodejs/node/issues/26852 on Node.js 10 and 12 + // Checking for stdin is workaround for https://github.com/nodejs/node/issues/26852 + // TODO: remove `|| spawned.stdin === undefined` once we drop support for Node <=12.2.0 if (input === undefined || spawned.stdin === undefined) { return; } From 7e55c53f9e9223aa194d944fb76c2bfd2119ea71 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Mon, 20 May 2019 21:03:58 +0700 Subject: [PATCH 2/2] Update index.js --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index ac229ae9b..3fbb53722 100644 --- a/index.js +++ b/index.js @@ -98,7 +98,7 @@ function handleArgs(command, args, options = {}) { function handleInput(spawned, input) { // Checking for stdin is workaround for https://github.com/nodejs/node/issues/26852 - // TODO: remove `|| spawned.stdin === undefined` once we drop support for Node <=12.2.0 + // TODO: Remove `|| spawned.stdin === undefined` once we drop support for Node.js <=12.2.0 if (input === undefined || spawned.stdin === undefined) { return; }