Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main cross character is incorrect #92

Closed
gibson042 opened this issue Aug 6, 2022 · 3 comments · Fixed by #93
Closed

Main cross character is incorrect #92

gibson042 opened this issue Aug 6, 2022 · 3 comments · Fixed by #93

Comments

@gibson042
Copy link
Contributor

(discovered while working on ava test result accessibility: avajs/ava#3082 )

The main cross character is U+2716 HEAVY MULTIPLICATION X "✖︎", but for accessibility (and proper contrast with tick U+2714 HEAVY CHECK MARK "✔︎") it should instead be U+2718 HEAVY BALLOT X "✘︎".

gibson042 added a commit to gibson042/figures that referenced this issue Aug 6, 2022
@ehmicky
Copy link
Collaborator

ehmicky commented Aug 7, 2022

Hi @gibson042,

I have tried to display U+2714 ✔, U+2716 ✖ and U+2718 ✘ on the following list of ~20 terminals with the default fonts. Apparently they all display correctly except:

  • None of them displays correctly on Windows Console Host (cmd.exe, Powershell) and mintty/Git-for-Windows (which is why we have a fallback with this library).
  • Only U+2718 ✘ displays correctly on the Linux kernel console (but that terminal is not officially supported)

From a style standpoint, ti seems to me that U+2718 ✘ is less bold and more slanted, so is closer to U+2714 ✔. From that angle, this makes sense to me as well.

That being said, could you please add some additional description as to what specifically makes U+2718 ✘ more accessible than U+2716 ✖, and for which type of accessibility?

Also, if you find some time, could you open a similar issue and/or PR with https://github.com/sindresorhus/log-symbols to keep those in sync? Thanks!

@gibson042
Copy link
Contributor Author

Sure, I'm primarily concerned about proper semantics and the corresponding consequences upon vision-impaired users. For example, screen readers are notoriously bad at symbols, and for example VoiceOver reads U+2716 HEAVY MULTIPLICATION X "✖︎" as "multiplication symbol", which is appropriate for that software because the character is in fact a multiplication symbol. But that has no obvious connection to negative status such as a test failure, and the fact that they are visually similar is insufficient reason to consider them as interchangeable.

@ehmicky
Copy link
Collaborator

ehmicky commented Aug 7, 2022

This makes sense, thanks for explaining! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants