Improve parsing TIFF files #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
issue-480-dng-detection
branch
2 times, most recently
from
8861872
to
a7230f6
Compare
Borewit
force-pushed
the
issue-480-dng-detection
branch
from
a7230f6
to
7493bdc
Compare
Detect DNG files in a reliable matter. Improve big-endian encoded TIFF detection. Fixes: #480
Borewit
force-pushed
the
issue-480-dng-detection
branch
from
7493bdc
to
31a7ffe
Compare
|
Nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The existing samples are truncated, so these are kind of stuck with old school magic byte pattern matching.
Therefor I replaced them with original files.
The updated Sony file type
.arwhas been a bit of guess. It basically looks for a tag, which looks like a Sony private tag. Other.arwmay or may not have this tags.Warning: fixtures are very large, 25 MB each!!!Truncated samples to 100.000 bytes each. This is enough to read it's tags.
Fixes #480
Source sample file
.arw: https://www.dpreview.com/sample-galleries/9547785333/