Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import path ITokenizer #553

Merged
merged 1 commit into from Aug 2, 2022
Merged

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Aug 2, 2022

I think the import path should be

import {ITokenizer} from 'strtok3';

as the export of strtok3 is (updated):

"exports": {
    ".": {
      "node": "./lib/index.js",
      "default": "./lib/core.js"
    },
    "./core": "./lib/core.js"
  },

where both index.js & core.js export ITokenizer

@Borewit Borewit added the bug label Aug 2, 2022
@Borewit Borewit self-assigned this Aug 2, 2022
@sindresorhus sindresorhus merged commit e843d73 into main Aug 2, 2022
@sindresorhus sindresorhus deleted the fix-typings-import-itokenizer branch August 2, 2022 21:25
@Borewit Borewit linked an issue Aug 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'strtok3/core' from 'node_modules/file-type/core.js'
3 participants