Fix descriptors copy #22
Merged
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Jul 24, 2022
| configurable: true, | ||
| }); | ||
| const descriptor = Object.getOwnPropertyDescriptor(object, key); | ||
| Object.defineProperty(result, key, descriptor); | ||
| } | ||
| } | ||
| } else { | ||
| // `for ... of Object.keys()` is faster than `for ... of Object.entries()`. | ||
| for (const key of Object.keys(object)) { | ||
| const value = object[key]; |
There was a problem hiding this comment.
Note: value and descriptor are retrieved separately, since descriptor.value !== value when descriptor.get is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
This ensures descriptors properties (
writable,configurable,get,set) are kept when copying.Note: we ignore non-enumerable properties, so
enumerableis alwaystrue.This is a bug fix. However, this could arguably be a breaking change for some consumers relying on the current (incorrect) behavior.