Fall back to a random port if preferred port is privileged #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgallag
referenced
this pull request
in garden-io/garden
Dec 17, 2019
sindresorhus
changed the title
mjgallag
deleted the
fall-back-to-a-random-port-if-prefered-port-is-privileged
branch
mjgallag
commented
Dec 18, 2019
| @@ -32,7 +32,7 @@ test('preferred port unavailable', async t => { | |||
| t.not(port, desiredPort); | |||
| }); | |||
|
|
|||
| test('preferred port priviliged', async t => { | |||
| test('preferred port privileged', async t => { | |||
There was a problem hiding this comment.
Oops, thanks for catching this typo @sindresorhus, and thanks for the quick merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the test is using
127.0.0.1so that it can run on MacOS, which stopped enforcing privileged ports in10.14and later, see https://news.ycombinator.com/item?id=18302380. Unfortunately, it's possible this is a bug and that Apple could fix it in the future, but test still passes as of MacOS10.15.2. The test will also fail if run as root on Linux, but I don't think they should typically be running as root. If anyone has any better ideas, please do suggest!Closes #38