Use native stream.pipeline instead of pump package
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagonapoli
force-pushed
the
master
branch
2 times, most recently
from
2c9e149
to
c082e7c
Compare
sindresorhus
reviewed
Jul 3, 2020
sindresorhus
reviewed
Jul 3, 2020
|
Travis is failing. |
|
Thanks for the review! I will correct the code :) |
I'll drop support for Node.js 8 after this PR is merged. |
sindresorhus
changed the title
stream.pipeline instead of pump package
|
Can you fix the merge conflict? Also see #39 (comment) |
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
|
FYI - Not meaningful for us, we were able to just remove uses of neat-csv, and thus remove the dependency. I'm not really asking for a change, just thought you may want to be aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the pump package with the native
stream.pipeline, introduced on node@10.0.0 (requested on #33). This fixes #38.Also, a nit, it replaces
return Promise.reject(new Error...)withthrow new Error...This is a breaking change