Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub dark theme #89

Merged
merged 5 commits into from Oct 17, 2021
Merged

Support GitHub dark theme #89

merged 5 commits into from Oct 17, 2021

Conversation

hyrious
Copy link
Collaborator

@hyrious hyrious commented Oct 16, 2021

With this PR, there will be 3 css files to be released in this package:

  • github-markdown.css: (default) Automatically switch between light and dark through @media (prefers-color-scheme).
    1the file name is not changed to be compatible with possible users.
  • github-markdown-light.css: Light only.
  • github-markdown-dark.css: Dark only.

1: while I'd like to keep being compatible as much as I can, they (the 4.0 file and this new one) are likely to be broken in many ways as you can see the diff. When that happens, please raise an issue and we could adjust the script in generate-github-markdown-css to fix them.

Related PR: sindresorhus/generate-github-markdown-css#12
Closes #76

@sindresorhus
Copy link
Owner

I would make the auto one the default, meaning github-markdown.css, and make github-markdown-dark.css and GitHub-markdown-light.css.

@sindresorhus sindresorhus merged commit 5a667d5 into main Oct 17, 2021
@sindresorhus sindresorhus deleted the 5.0 branch October 17, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitHub dark theme
2 participants