Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue in windows #179

Open
yellowjian opened this issue Jul 7, 2021 · 2 comments
Open

issue in windows #179

yellowjian opened this issue Jul 7, 2021 · 2 comments

Comments

@yellowjian
Copy link

yellowjian commented Jul 7, 2021 •
edited

image

use await globby(globPattern) and has files in globPattern. but globby cannot find any file in pattern.
@fschwalm
Copy link

Hello @yellowjian!
Do you found any solutions or workarounds?

thank you

@rmcooper
Copy link

rmcooper commented Dec 9, 2021

Came here with the same problem, but after some research found that the glob pattern must only contain forward slashes. For example:

await globby(path.join(__dirname, 'files', '**').replace(/\\/g, '/'))

@pissang pissang mentioned this issue Dec 23, 2021
Merged
@Julien-R44 Julien-R44 mentioned this issue Dec 27, 2021
Merged
@berwin0415 berwin0415 mentioned this issue Jan 19, 2022
Closed
@jopemachine jopemachine mentioned this issue Mar 31, 2022
Merged
@dimovpetar dimovpetar mentioned this issue Jun 16, 2022
Merged
This was referenced Jun 23, 2022
Closed
Closed
@techmatt101 techmatt101 mentioned this issue Jun 30, 2022
Merged
JacobLey pushed a commit to JacobLey/jacobley that referenced this issue Jul 1, 2022
@techmatt101 @JacobLey
fixed path glob separator on Windows
a4a3ae8 
globby requires the use of forward slashes as path separators and on Windows OS Path.join will use backslashes in creating the path. This change replaces backslashes to forward slashes to fix globby results for Windows. More info sindresorhus/globby#179
@SeanKilleen SeanKilleen mentioned this issue Oct 8, 2022
Merged
3 tasks
140948940 added a commit to 140948940/router that referenced this issue Mar 15, 2023
@140948940
chore:modify the way to get folders
21e862a 
globby is have a bug in windows,can see this issues :sindresorhus/globby#179.
It's not a serious bug，But it makes learning to code tricky.
@140948940 140948940 mentioned this issue Mar 15, 2023
Merged
@SaekiTominaga SaekiTominaga mentioned this issue Apr 6, 2023
Merged
This was referenced Oct 29, 2023
Closed
Merged
@davidfirst davidfirst mentioned this issue Feb 6, 2024
Merged
davidfirst added a commit to teambit/bit that referenced this issue Feb 7, 2024
@davidfirst
fix(tag), save app artifacts into the objects on Windows (#8504)
e490690 
We use `globby` package to resolve paths from the artifacts definition.
The `app-bundle` artifact has `'artifacts/app-bundle'` pattern on
linux/mac but `artifacts//app-bundle` on Windows.
Turns out that globby [doesn't support Windows
paths](sindresorhus/globby#179). This PR
changes the paths to Linux before sending to globby.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmcooper @fschwalm @yellowjian