Fix got.mergeOptions(...) types (#953)

sindresorhus · Dec 6, 2019 · b962d08 · b962d08
1 parent 22e72c8
commit b962d08
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/source/create.ts b/source/create.ts
@@ -1,4 +1,4 @@
-import {Merge, PartialDeep} from 'type-fest';
+import {Merge} from 'type-fest';
 import asPromise from './as-promise';
 import asStream, {ProxyStream} from './as-stream';
 import * as errors from './errors';
@@ -70,7 +70,7 @@ export interface Got extends Record<HTTPAlias, GotFunctions>, GotFunctions {
 
 	extend(...instancesOrOptions: Array<Got | ExtendOptions>): Got;
 	mergeInstances(parent: Got, ...instances: Got[]): Got;
-	mergeOptions<T extends PartialDeep<Options>>(...sources: T[]): T;
+	mergeOptions(...sources: Options[]): NormalizedOptions;
 }
 
 export interface GotStream extends Record<HTTPAlias, ReturnStream> {

diff --git a/test/normalize-arguments.ts b/test/normalize-arguments.ts
@@ -0,0 +1,11 @@
+import test from 'ava';
+import got from '../source';
+
+test('should merge options replacing responseType', t => {
+	const responseType = 'json';
+	const options = got.mergeOptions(got.defaults.options, {
+		responseType
+	});
+
+	t.is(options.responseType, responseType);
+});