Fix type conflicts for URL and URLSearchParams types (#983)

package.json

@@ -125,7 +125,9 @@
 			"documentation/examples/*"
 		],
 		"rules": {
-			"@typescript-eslint/no-empty-function": "off"
+			"@typescript-eslint/no-empty-function": "off",
+			"node/prefer-global/url": "off",
+		  	"node/prefer-global/url-search-params": "off"
 		}
 	}
 }

source/normalize-arguments.ts

@@ -1,3 +1,4 @@
+import {URL, URLSearchParams} from 'url';
 import {promisify} from 'util';
 import CacheableRequest = require('cacheable-request');
 import http = require('http');
@@ -234,6 +235,7 @@ export const normalizeArguments = (url: URLOrOptions, options?: Options, default
 	}
 
 	if (is.urlInstance(url) || is.string(url)) {
+		// @ts-ignore URL is not URL
 		options.url = url;
 
 		options = mergeOptions(defaults?.options ?? {}, options);

source/request-as-event-emitter.ts

@@ -2,6 +2,7 @@ import CacheableRequest = require('cacheable-request');
 import EventEmitter = require('events');
 import http = require('http');
 import stream = require('stream');
+import {URL} from 'url';
 import {promisify} from 'util';
 import is from '@sindresorhus/is';
 import timer from '@szmarczak/http-timer';
@@ -239,7 +240,7 @@ export default (options: NormalizedOptions): RequestAsEventEmitter => {
 		} else {
 			// Catches errors thrown by calling `requestFn(…)`
 			try {
-				// @ts-ignore URLSearchParams does not equal URLSearchParams
+				// @ts-ignore ResponseObject does not equal IncomingMessage
 				handleRequest(httpOptions.request(options.url, httpOptions, handleResponse));
 			} catch (error) {
 				emitError(new RequestError(error, options));

source/utils/merge.ts

@@ -1,3 +1,4 @@
+import {URL} from 'url';
 import is from '@sindresorhus/is';
 import {Merge} from 'type-fest';
 

source/utils/options-to-url.ts

@@ -1,3 +1,5 @@
+import {URL, URLSearchParams} from 'url';
+
 function validateSearchParams(searchParams: Record<string, unknown>): asserts searchParams is Record<string, string | number | boolean | null> {
 	for (const value of Object.values(searchParams)) {
 		if (typeof value !== 'string' && typeof value !== 'number' && typeof value !== 'boolean' && value !== null) {

source/utils/types.ts

@@ -4,6 +4,7 @@ import Keyv = require('keyv');
 import CacheableRequest = require('cacheable-request');
 import PCancelable = require('p-cancelable');
 import ResponseLike = require('responselike');
+import {URL} from 'url';
 import {Readable as ReadableStream} from 'stream';
 import {Timings} from '@szmarczak/http-timer';
 import CacheableLookup from 'cacheable-lookup';
@@ -247,44 +248,3 @@ export interface CancelableRequest<T extends Response | Response['body']> extend
 	buffer(): CancelableRequest<Buffer>;
 	text(): CancelableRequest<string>;
 }
-
-// TODO: Remove this when https://github.com/DefinitelyTyped/DefinitelyTyped/issues/34960 is resolved
-declare global {
-	// @ts-ignore TypeScript complains about duplicated identifier.
-	class URL {
-		readonly origin: string;
-		readonly searchParams: URLSearchParams;
-		hash: string;
-		host: string;
-		hostname: string;
-		href: string;
-		password: string;
-		pathname: string;
-		port: string;
-		protocol: string;
-		search: string;
-		username: string;
-
-		constructor(input: string, base?: string | URL);
-		toString(): string;
-		toJSON(): string;
-	}
-
-	// @ts-ignore TypeScript complains about duplicated identifier.
-	class URLSearchParams implements Iterable<[string, string]> {
-		constructor(init?: URLSearchParams | string | {[key: string]: string | string[] | undefined} | Iterable<[string, string]> | Array<[string, string]>);
-		append(name: string, value: string): void;
-		delete(name: string): void;
-		entries(): IterableIterator<[string, string]>;
-		forEach(callback: (value: string, name: string, searchParams: this) => void): void;
-		get(name: string): string | null;
-		getAll(name: string): string[];
-		has(name: string): boolean;
-		keys(): IterableIterator<string>;
-		set(name: string, value: string): void;
-		sort(): void;
-		toString(): string;
-		values(): IterableIterator<string>;
-		[Symbol.iterator](): IterableIterator<[string, string]>;
-	}
-}

source/utils/url-to-options.ts

@@ -1,4 +1,4 @@
-import {UrlWithStringQuery} from 'url';
+import {URL, UrlWithStringQuery} from 'url';
 import is from '@sindresorhus/is';
 
 // TODO: Deprecate legacy URL at some point

test/arguments.ts

@@ -1,5 +1,5 @@
 /* eslint-disable node/no-deprecated-api */
-import {parse} from 'url';
+import {parse, URL, URLSearchParams} from 'url';
 import test from 'ava';
 import {Handler} from 'express';
 import pEvent = require('p-event');

test/create.ts

@@ -1,4 +1,5 @@
 import {Agent as HttpAgent, IncomingMessage, request as httpRequest, RequestOptions} from 'http';
+import {URL} from 'url';
 import test from 'ava';
 import is from '@sindresorhus/is';
 import {Handler} from 'express';

test/url-to-options.ts

@@ -1,4 +1,5 @@
 import url = require('url');
+import {URL} from 'url';
 import test from 'ava';
 import urlToOptions from '../source/utils/url-to-options';