Avoid parsing JSON twice in _pagination.transform (#1102)

sindresorhus · Mar 3, 2020 · cf4fdad · cf4fdad
1 parent 62f3f38
commit cf4fdad
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/source/index.ts b/source/index.ts
@@ -69,6 +69,10 @@ const defaults: Defaults = {
 		context: {},
 		_pagination: {
 			transform: (response: Response) => {
+				if (response.request.options.responseType === 'json') {
+					return response.body;
+				}
+
 				return JSON.parse(response.body as string);
 			},
 			paginate: response => {

diff --git a/test/pagination.ts b/test/pagination.ts
@@ -47,6 +47,16 @@ test('retrieves all elements', withServer, async (t, server, got) => {
 	t.deepEqual(result, [1, 2]);
 });
 
+test('retrieves all elements with JSON responseType', withServer, async (t, server, got) => {
+	attachHandler(server, 2);
+
+	const result = await got.extend({
+		responseType: 'json'
+	}).paginate.all('');
+
+	t.deepEqual(result, [1, 2]);
+});
+
 test('points to defaults when extending Got without custom `_pagination`', withServer, async (t, server, got) => {
 	attachHandler(server, 2);