Retry when timing-out question

[patryk-smc]

What would you like to discuss?

I'm dealing with quite unresponsive API and would like to retry request up to 3 times if response is taking longer than 1000 ms.

For that, I'm using options:

timeout: 1000,
retry: 3,

However, when I inspect requests with my instrumenting tool, I can see that first request took more than 2000 ms.

I would expect that a second request would occur after 1000 ms.

What I'm missing here? Are my options not valid for what I want to achieve?

Checklist

• I have read the documentation.

[szmarczak]

Delays between retries counts with function 1000 * Math.pow(2, retry - 1) + Math.random() * 100, where retry is attempt number (starts from 1).

https://github.com/sindresorhus/got#retry

[szmarczak]

Or, if you want to retry immediately, use 1 instead.

[patryk-smc]

Thanks,
do you have an idea why limit is not respected here?

    got({
      method: "get",
      url: "http://httpstat.us/200?sleep=5000",
      timeout: 1000,
      retry: {
        limit: 3,
        calculateDelay: ({ attemptCount, retryOptions }) => {
          console.log(
            "Retry:",
            { attemptCount, limit: retryOptions.limit },
            new Date().toISOString()
          );
          return 1;
        },
      },
      responseType: "json",
    })

Returns:

Retry: { attemptCount: 1, limit: 3 } 2021-02-17T21:17:23.177Z
Retry: { attemptCount: 2, limit: 3 } 2021-02-17T21:17:24.183Z
Retry: { attemptCount: 3, limit: 3 } 2021-02-17T21:17:25.191Z
Retry: { attemptCount: 4, limit: 3 } 2021-02-17T21:17:26.199Z
Retry: { attemptCount: 5, limit: 3 } 2021-02-17T21:17:27.208Z
Retry: { attemptCount: 6, limit: 3 } 2021-02-17T21:17:28.217Z
Retry: { attemptCount: 7, limit: 3 } 2021-02-17T21:17:29.225Z
Retry: { attemptCount: 8, limit: 3 } 2021-02-17T21:17:30.231Z
Retry: { attemptCount: 9, limit: 3 } 2021-02-17T21:17:31.235Z
Retry: { attemptCount: 10, limit: 3 } 2021-02-17T21:17:32.241Z
Retry: { attemptCount: 11, limit: 3 } 2021-02-17T21:17:33.245Z
Retry: { attemptCount: 12, limit: 3 } 2021-02-17T21:17:34.252Z
Retry: { attemptCount: 13, limit: 3 } 2021-02-17T21:17:35.259Z
Retry: { attemptCount: 14, limit: 3 } 2021-02-17T21:17:36.267Z
...and so on

I got it sorted out with return attemptCount < retryOptions.limit ? 1 : 0; but it would be nice to know if there is better way.

[szmarczak]

do you have an idea why limit is not respected here?

Yes. You didn't handle the limit option, therefore it had no effect. It's all in the docs.

it would be nice to know if there is better way.

#1614 (reply in thread)

[szmarczak]

Unless you want something different, then you should make your question more precise.

[zeing]

let inputStream = got.stream(
    url,
    {
      isStream: true,
      timeout: 500,
      retry: {
        calculateDelay: ({ attemptCount, retryOptions }) => {
          console.log(
            'Retry:',
            { attemptCount, limit: retryOptions.limit },
            new Date().toISOString()
          )
          return 1
        },
      },
    }
  )

I have got like

node:events:368
      throw er; // Unhandled 'error' event
      ^

RequestError: Timeout awaiting 'request' for 500ms