Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 10 support #1319

Closed
1 task done
NMinhNguyen opened this issue Jun 16, 2020 · 2 comments
Closed
1 task done

Node.js 10 support #1319

NMinhNguyen opened this issue Jun 16, 2020 · 2 comments

Comments

@NMinhNguyen
Copy link

What would you like to discuss?

I noticed in #1051 (comment) that the minimum version of Node was bumped from just 10 to 10.19.0 (via engines) and I wanted to ask why that happened. Is the current version of got relying on a feature/bugfix not available in 10.0.0? Arguably, it should be listed as a breaking change in v11 release notes.

Checklist

  • I have read the documentation.
@sindresorhus
Copy link
Owner

Is the current version of got relying on a feature/bugfix not available in 10.0.0?

Yes

Arguably, it should be listed as a breaking change in v11 release notes.

Updated

@NMinhNguyen
Copy link
Author

Thanks @sindresorhus! Mind sharing what this feature/bugfix is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @NMinhNguyen