Uncaught error: The header content contains invalid characters

[pietermees]

I've been seeing occasional uncaught exceptions:

Uncaught error: TypeError: The header content contains invalid characters 
   at get (/var/app/current/node_modules/got/index.js:49:18) 
   at Immediate.setImmediate (/var/app/current/node_modules/got/index.js:124:3)

Scanning the code it seems that errors thrown directly by http.request or https.request on that line are not caught.

This is happening on a server that processes a very large number of http requests and I haven't been able to track down which requests cause this error.

[sindresorhus]

What exact version of Got do you have installed and how are you using it (Promise API or Streaming)?

[sindresorhus]

Wonder if it's something like request/request#2120 or https://stackoverflow.com/questions/43194065/node-js-http-typeerror-the-header-content-contains-invalid-characters

[pietermees]

That would be 7.1.0 and Promise mode

…

On Sat, Aug 5, 2017 at 7:43 AM Sindre Sorhus ***@***.***> wrote: What exact version of Got do you have installed and how are you using it (Promise API or Streaming)? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#353 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG3lJXs6no_dGb3T8aiwuFB5XcZ7DfFwks5sVFVSgaJpZM4OuIJB> .

[sindresorhus]

I think this is fixed in master. Could you try running master?

I could reproduce the unhandled exception when I put a throw statement in 7.1.0 here:

got/index.js

Line 48 in b725ef5

When I did the same in master, it was handled, since we now correctly catch and propagate errors:

got/index.js

Lines 258 to 260 in 8b040af

	.catch(err => {
	ee.emit('error', err);
	});

[pietermees]

When I update to the latest commit on master and run my test suite, the process never exits and I'm getting a (node:56384) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added. Use emitter.setMaxListeners() to increase limit warning.

Could it be that some sort of memory leak was introduce in the master codebase since 7.1.0?

[sindresorhus]

Not sure. Usually, that warning is just an annoying false positive though. Try to reduce your test suite until it runs again to narrow down what's causing it.

[pietermees]

Yeah, I've noticed ;) Although in this case it does seem to correlate with a bigger issue of my process not exiting. No other errors or warnings though.

…

On Mon, Aug 7, 2017 at 5:05 PM Sindre Sorhus ***@***.***> wrote: Not sure. Usually, that warning is just an annoying false positive though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#353 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG3lJUuFpEQAAEe30YYrTWQXDZ4JMgvkks5sV3wpgaJpZM4OuIJB> .

[pietermees]

I've been able to replicate this in my load tests. It seems that more and more listeners are added somewhere in the code and not cleaned up. Could it be that if a request fails some listeners are not removed?

Could this be somehow related to me using agentkeepalive to reuse sockets? Others might not be running into this if sockets are not being reused for thousands of requests?

[petitchevalroux]

@pietermees as stated in #382 original issue seems ok in master branch

I get the MaxListenersExceededWarning warning too on connect and request event but it may be better to open a new issue

[pietermees]

@petitchevalroux seems like @timdp opened up a new issue for the memory leak
I'll close this issue