Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS cache #731

Merged
merged 2 commits into from Feb 21, 2019
Merged

Add DNS cache #731

merged 2 commits into from Feb 21, 2019

Conversation

szmarczak
Copy link
Collaborator

Fixes #661

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

szmarczak
szmarczak commented Feb 19, 2019
View reviewed changes
source/as-stream.ts
@@ -76,13 +76,13 @@ export default function asStream(options: MergedOptions) {
throw new Error('Failed to pipe. The response has been emitted already.');
}

const result = pipe(destination, options);
pipe(destination, options);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior is the same, this just fixes some some linting error :P

@sindresorhus sindresorhus changed the title DNS cache Add DNS cache Feb 21, 2019
@sindresorhus sindresorhus merged commit cd12351 into sindresorhus:master Feb 21, 2019
@Kikobeats Kikobeats mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szmarczak @sindresorhus