Move top-level error properties into an .options
and .response
property
#773
+74
−93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just simplifies error properties. As for now you can access error options in two ways:
error.hostname
error.gotOptions.hostname
They return the same value. So I removed
Object.assign(this, options);
and renamedgotOptions
tooptions
. So you need to do justerror.options.hostname
.Same with the
response
property. Instead oferror.statusCode
you need to doerror.response.statusCode
.Checklist