Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not import package.json #911

Merged
merged 2 commits into from Nov 3, 2019
Merged

Do not import package.json #911

merged 2 commits into from Nov 3, 2019

Conversation

szmarczak
Copy link
Collaborator

Fixes #891

@sindresorhus
Copy link
Owner

You need to remove it in the test too.

@szmarczak
Copy link
Collaborator Author

Yeah, trying to fix this and that...

@szmarczak
Copy link
Collaborator Author

Is it possible to test publishing somehow? E.g. using Travis?

@sindresorhus
Copy link
Owner

Not sure. Something more useful would be a TS lint rule to prevent importing package.json.

@sindresorhus sindresorhus merged commit 95bed1e into sindresorhus:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix building Got
2 participants
@szmarczak @sindresorhus