Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use socket instead of connection #915

Merged
merged 4 commits into from Nov 4, 2019
Merged

Use socket instead of connection #915

merged 4 commits into from Nov 4, 2019

Conversation

Zauberbutter
Copy link
Contributor

The request.connection and response.connection properties are now runtime deprecated. (#827)

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

Use socket instead of connection
750c519 
The request.connection and response.connection properties are now runtime deprecated.
@sindresorhus
Copy link
Owner

Looks like the node typings are not updated yet. Just use a // @ts-ignore comment.

@sindresorhus
Copy link
Owner

Can you also add Node 13 to Travis.yml to ensure it works.

@Zauberbutter
Copy link
Contributor Author

I wonder why the error occurs because socket is there: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/http.d.ts#L297

@sindresorhus sindresorhus merged commit b0dfc95 into sindresorhus:master Nov 4, 2019
@Zauberbutter Zauberbutter deleted the patch-1 branch November 4, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zauberbutter @sindresorhus @szmarczak