New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrying inside `afterResponse` hook should trigger `beforeRetry` hook #918

Closed

szmarczak opened this issue Nov 4, 2019 · 0 comments · Fixed by #921

Labels

enhancement ✭ help wanted ✭

Collaborator

szmarczak commented Nov 4, 2019

Just add

					for (const hook of options.hooks.beforeRetry) {
						// eslint-disable-next-line no-await-in-loop
						await hook(options, error, retryCount);
					}

and make some tests.

got/source/as-promise.ts

Line 86 in b0dfc95

szmarczak added enhancement ✭ help wanted ✭ labels

szmarczak mentioned this issue

Major refactoring #921

Merged

22 tasks

sindresorhus closed this as completed in #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment