Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type conflicts for URL and URLSearchParams types #983

Merged
merged 2 commits into from Dec 12, 2019
Merged

Fix type conflicts for URL and URLSearchParams types #983

merged 2 commits into from Dec 12, 2019

Conversation

pmmmwh
Copy link
Contributor

@pmmmwh pmmmwh commented Dec 10, 2019

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

Fixes #980

szmarczak
szmarczak reviewed Dec 10, 2019
View reviewed changes
source/normalize-arguments.ts
@@ -1,3 +1,4 @@
import {URL, URLSearchParams} from 'url';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a TODO comment in the same line to remove this when TypeScript gets fixed

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better to open an issue about this as adding a TODO comment to every single import would be noisy.

@sindresorhus sindresorhus changed the title Fix URL types using URL imports Fix type conflicts for URL and URLSearchParams types Dec 12, 2019
@sindresorhus sindresorhus merged commit cd4226d into sindresorhus:master Dec 12, 2019
@szmarczak szmarczak mentioned this pull request Dec 12, 2019
Closed
@pmmmwh pmmmwh deleted the fix/url-types-from-import branch December 22, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@szmarczak szmarczak szmarczak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate identifier URLSearchParams and URL in compiling got@10.0.2 with typescript@3.7.3
3 participants
@pmmmwh @sindresorhus @szmarczak