Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't zip if folder name contains [square brackets] #93

Open
huguestennier opened this issue Jul 13, 2017 · 2 comments
Open

Won't zip if folder name contains [square brackets] #93

huguestennier opened this issue Jul 13, 2017 · 2 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt

Comments

@huguestennier
Copy link

huguestennier commented Jul 13, 2017

Issuehunt badges

If you try to zip within a directory that contains [square brackets] - it looks like the process goes through (even npm test passes) but in reality it will fail to zip.


IssueHunt Summary

Sponsors (Total: $30.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 9, 2019
@IssueHuntBot
Copy link

@issuehunt has funded $30.00 to this issue.


@bobthekingofegypt
Copy link

I just had a look at this issue. There is not a lot of details here and its a pretty old bug. I'm going to assume you were using gulp.src to pipe into gulp zip in which case this is not a bug in gulp-zip, it was a bug in the glob library used by gulp.

gulpjs/gulp#616

Testing on linux and macos double escaping [ and ] works with gulp@4.

const gulp = require('gulp');
const zip = require('gulp-zip');

gulp.task('default', () =>
	gulp.src('\\[src\\]/*')
		.pipe(zip('archive.zip'))
		.pipe(gulp.dest('dist'))
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt
Projects
None yet
Development

No branches or pull requests

3 participants