Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser version needs improvement #13

Open
silverwind opened this issue Feb 1, 2017 · 3 comments
Open

Browser version needs improvement #13

silverwind opened this issue Feb 1, 2017 · 3 comments

Comments

@silverwind
Copy link
Collaborator

silverwind commented Feb 1, 2017

favicon.ico is unreliable on modern sites that use SVG or PNG favicons, which could also be inlined as a datauri. I think we need to get creative and find better methods. Maybe a <script> tag could be of use because it's inherently cross-origin compatible.

@silverwind silverwind changed the title Browser version needs improvment Browser version needs improvement Feb 1, 2017
@sindresorhus
Copy link
Owner

It's only unreliable when you don't know the site it's going to be used one. Favicon serves the purpose of is-online fine as we have a hardcoded list of hosts, but since this module accepts user specified hosts, I guess this makes sense. Or we could just document that the hosts needs to have a /favicon.ico.

@detj
Copy link

detj commented Feb 22, 2021

@sindresorhus should also document that the timeout option will not work in browsers. #50

@detj
Copy link

detj commented Feb 22, 2021

@sindresorhus should also document that the timeout option will not work in browsers. #50

landed in 4dd216c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants