New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is.propertyKey
#138
Add is.propertyKey
#138
Conversation
@sindresorhus older version of Typescript may not include |
You need to add it to the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test needs a fix, otherwise looks good. Never knew PropertyKey
was a built-in type, always used keyof any
instead. Thanks for the info :)
Co-authored-by: Giora Guttsait <giora111@gmail.com>
Ouch! I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment about the comment wasn't fixed. I believe this would be the last change
@PopGoesTheWza thanks for your contribution bro 🤘🏻 |
On a totally irrelevant and lighthearted matter, I viscerally hate the term "bro". I can do with "dude" or "mate" though... ;) |
@PopGoesTheWza I swear I thought about it ASA I posted the comment 😅 Thanks for pointing it out 🙏🏻 |
Fixes #136