New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response
to beforeRetry
hook and change its parameter to a single object
#201
Conversation
Should we make all hooks take an object for consistency? Or only once they grow to this many arguments? Also, what do you think of my idea to attach the response to the request as |
|
Yeah, let's change the other ones too. |
You need to update the readme (https://github.com/sindresorhus/ky#hooksbeforeretry), examples, and relevant tests too. |
@lkostrowski Bump :) |
Sorry I was on vacation. I will try to finish it during xmas |
Bump :) |
Should be fine, sorry for delay |
You need to update the docs text too, not just the examples. |
response
to beforeRetry
hook and change its parameter to a single object
Thanks :) |
Fixes #194