Fix request cancellation on timeout #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you open an issue about writing a test for this? So we'll get to it eventually. |
Done: #239 |
|
Great. Thanks for fixing this. Would you be able to take a quick look at #235? I'd like to get out a new version today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
This PR fixes a regression that was caused by a simple refactoring mistake in PR #180, which caused the request to not be aborted after a TimeoutError.
Unfortunately, while I did confirm that it works, I haven't figured out how to write a test for it. I was expecting that the abort operation would cause the client to hang up the connection, and I figured that would cause an
errorevent on the test server'srequestobject that I could watch for. But the abort doesn't seem to cause such an error to occur. I'm not familiar enough with the details of what AbortController does at the network connection / HTTP layer to know if there's anything else to look for.