New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting searchParams to URLSearchParams both in create() and get() doesn't merge them correctly #491
Comments
Please try with the latest Ky version. |
Part of the original issue here is fixed (Ky 1.2.3, Node 21.6.2): const client = ky.create({ searchParams: { api: 123 } });
client.get('', { searchParams: { _limit_: 1 } });
// http://localhost:8080/?api=123&_limit_=1
client.get('', { searchParams: new URLSearchParams({ _limit_: 1 }) })
// http://localhost:8080/?api=123 So the const form1 = new FormData();
form1.append('foo', 'bar');
const form2 = new FormData();
form2.append('bar', 'baz');
const client = ky.create({ searchParams: new URLSearchParams({ api: 123 }), body: form1 });
const response = await client.post('', { searchParams: new URLSearchParams({ _limit_: 1 }), body: form2 });
console.log(response.url);
// Expected: https://localhost:8080/?api=123&_limit_=1
// Actual: https://localhost:8080/?
console.log(response.text());
// Expected: Big dump of form data
// Actual: [object Object]
console.log(response.type);
// Expected: multipart/form-data
// text/plain;charset=utf-8 All sorts of wrong. Really, this is an issue in how
But despite my recommendation, I'm not familiar enough with the implementation or the maintainer's intended/desired behaviors to really make a judgement call on what's the best approach for a PR. Either way, we'd definitely need to specifically document this behavior for users, and it may be worth adding some tests to the test suite to watch out for regressions in the future. Merging objects can be a bit finicky and occasionally isn't forward compatible (e.g. Lodash not being able to handle |
Steps to reproduce (v. 0.27.0, tested in Firefox 110.0.1):
Variant A
The URL visited is
http://localhost:8080/?headers=[object Object]
, instead ofhttp://localhost:8080/?api=123&_limit_=1
.Variant B
The URL visited is
http://localhost:8080/?api=456&headers=[object Object]
, instead ofhttp://localhost:8080/?api=456&_limit_=1
.The text was updated successfully, but these errors were encountered: