Print a useful error if package.json is missing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sole.log error that package.json is missing
|
Please spend some more time on the code. |
|
Yeah, I saw the travis build fail, I will working on it. But beside that, did you saw something wrong? |
satazor
suggested changes
Jul 28, 2019
|
Can you change the pull request title to be more descriptive? It should concisely explain what this PR fixes. Also include |
index.js
Outdated
| @@ -11,6 +11,11 @@ module.exports = (grunt, options = {}) => { | |||
|
|
|||
| let cwd = process.cwd(); | |||
| let config = options.config || pkgUp.sync(); | |||
|
|
|||
| if (config === null) { | |||
| grunt.fail.fatal('package.json not found.\nPlease make sure to create a package.json and install all dependecies before run a grunt task.'); | |||
There was a problem hiding this comment.
You have some typos.
Suggested change
| grunt.fail.fatal('package.json not found.\nPlease make sure to create a package.json and install all dependecies before run a grunt task.'); | |
| grunt.fail.fatal('package.json not found.\nPlease make sure to create a package.json and install all dependencies before you run Grunt.'); |
nunospot
changed the title
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This fixes #60
If I understand it right we need to check if the package.json is missing or not, like @kirbysayshi said it on the issue.
In this case I made a small condition to check this
['undefined', null].indexOf(config) > 0.Let me know if there is more about this issue than this.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor