Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance of getting the binaries signed for the term-size package? #2

Closed
rvagg opened this issue Jan 22, 2020 · 0 comments · Fixed by #3
Closed

Any chance of getting the binaries signed for the term-size package? #2

rvagg opened this issue Jan 22, 2020 · 0 comments · Fixed by #3

Comments

@rvagg
Copy link
Contributor

rvagg commented Jan 22, 2020

Hey @sindresorhus, we're dealing with the macOS notarization drama for the Node.js .pkg downloadables. We have to codesign binaries and packagesign the .pkg files (we've always done these) and now we have to notarize the .pkg files and staple the notarization in order for them to get past the new Gatekeeper on macOS Catalina. Otherwise, users get an error when trying to install.

Node bundles npm which bundles boxen which bundles term-size which bundles this executable in vendor/macos. When we notarize the Node.js .pkg files we get warnings from Apple about this executable being unsigned. Apparently next month those warnings are going to turn in to fatal errors.

Before we explore alternatives I wanted to check whether there was any chance you could start codesigning the binary when you vendor it in to term-size? It requires an Apple Developer membership to get a certificate and some hoop-jumping but can be scripted. "no" is a reasonable response IMO but I thought we ought to check.

Ref: nodejs/node#31459
Ref: https://gist.github.com/rvagg/d9befda67accfe1355f7cf6da399980b

rvagg added a commit to rvagg/macos-term-size that referenced this issue Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant