Gracefully handle package.json not being found #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`read-pkg-up`'s `sync()` can return undefined. If that happens, we try to index into `.packageJson`, which fails. Making the index operation null-safe makes execution continue on with `pkg` being set to an empty object, which is what seems to be the original intent.
|
You cannot use this syntax. It's not supported in all the supported Node.js versions. |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read-pkg-up'ssync()can return undefined.If that happens, we try to index into
.packageJson, which fails.Making the index operation null-safe makes execution continue on with
pkgbeing set to an empty object, which is what seems to be the original intent.