Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open a GitHub Releases draft after publish #308

Merged
merged 14 commits into from
Jan 13, 2019
Merged

Open a GitHub Releases draft after publish #308

merged 14 commits into from
Jan 13, 2019

Conversation

yaodingyd
Copy link
Contributor

@yaodingyd yaodingyd commented Dec 26, 2018 •
edited

fix #306

@yaodingyd yaodingyd changed the title add new-github-release-url integration #306 add new-github-release-url integration Dec 28, 2018
brandon93s
brandon93s suggested changes Jan 1, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
brandon93s
brandon93s suggested changes Jan 1, 2019
View reviewed changes
index.js Show resolved Hide resolved
@brandon93s
Copy link

The test runner is using a floating version, always pulling latest. To fix the build replace t.throws with t.throwsAsync: https://travis-ci.org/sindresorhus/np/jobs/474594796

@yaodingyd
Copy link
Contributor Author

@brandon93s thanks. I resolved the issue.

sonicdoe
sonicdoe reviewed Jan 3, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus requested changes Jan 9, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
lib/ui.js Outdated Show resolved Hide resolved
lib/ui.js Outdated Show resolved Hide resolved
lib/ui.js Outdated Show resolved Hide resolved
lib/ui.js Outdated Show resolved Hide resolved
lib/release.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title add new-github-release-url integration Open a GitHub Releases draft after publish Jan 9, 2019
sindresorhus
sindresorhus requested changes Jan 11, 2019
View reviewed changes
lib/prerequisite.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

If the new version is a semver prerelease (e.g. 0.1.0-beta.1), I think we should we check the prerelease checkbox in the GitHub Releases draft. https://github.com/sindresorhus/new-github-release-url#isprerelease

@sindresorhus
Copy link
Owner

Actually, this is not fixed yet. It still shows the full commit URL in release notes.

- Unicorns  https://github.com/sindresorhus/sindre-playground/commit/6346413

Should be:

- Unicorns  6346413

@sindresorhus
Copy link
Owner

Can you also add a sentence about support for creating release drafts to the Why section in the readme? https://github.com/sindresorhus/np#why

@sindresorhus
Copy link
Owner

Other than the last two nitpicks. This is good to go.

@sindresorhus sindresorhus mentioned this pull request Jan 12, 2019
Closed
@yaodingyd
Copy link
Contributor Author

I'm so glad GitHub has the squash merge option...

@sindresorhus sindresorhus merged commit 1db6269 into sindresorhus:master Jan 13, 2019
@sindresorhus
Copy link
Owner

Merged. Yay! Very nice work on this, @yaodingyd ✨

sindresorhus added a commit that referenced this pull request Jan 14, 2019
@sindresorhus
Fix issue with #308 when there are no commits
71d7b2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonicdoe sonicdoe sonicdoe left review comments

@brandon93s brandon93s brandon93s requested changes

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new-github-release-url to give link to prefilled release notes w/commits
4 participants
@yaodingyd @brandon93s @sindresorhus @sonicdoe