Use $ npm ci if there is a lockfile
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Dec 28, 2018
sindresorhus
changed the title
$ npm ci if there is lockfile
index.js
Outdated
| @@ -46,6 +47,7 @@ module.exports = async (input = 'patch', options) => { | |||
| const pkg = util.readPkg(); | |||
| const pkgManager = options.yarn === true ? 'yarn' : 'npm'; | |||
| const pkgManagerName = options.yarn === true ? 'Yarn' : 'npm'; | |||
| const hasLockFile = fs.existsSync('package-lock.json') || fs.existsSync('npm-shrinkwrap.json'); | |||
There was a problem hiding this comment.
I just realized, you have to make the paths here relative to the package root, as it should be possible to run np in a sub-folder.
You can get the root path with https://github.com/sindresorhus/pkg-dir
sindresorhus
changed the title
$ npm ci if there is lockfile$ npm ci if there is a lockfile
sindresorhus
reviewed
Jan 3, 2019
index.js
Outdated
| @@ -65,6 +70,7 @@ module.exports = async (input = 'patch', options) => { | |||
| tasks.add([ | |||
| { | |||
| title: 'Cleanup', | |||
| skip: hasLockFile, | |||
sindresorhus
reviewed
Jan 3, 2019
index.js
Outdated
| task: () => exec('npm', ['install', '--no-package-lock', '--no-production']) | ||
| task: () => { | ||
| const args = hasLockFile ? ['ci'] : ['install', '--no-package-lock', '--no-production']; | ||
| exec('npm', args); |
There was a problem hiding this comment.
You forgot to return this, so the task would wait for it.
sindresorhus
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285