Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify installed Yarn version is >=1.7.0 #360

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Verify installed Yarn version is >=1.7.0 #360

merged 4 commits into from
Mar 16, 2019

Conversation

itaisteinherz
Copy link
Collaborator

@itaisteinherz itaisteinherz commented Mar 6, 2019 •
edited

See #248 (comment) and #248.

Fixes #248

aladdin-add
aladdin-add approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

source/npm-util.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 14, 2019
View reviewed changes
source/npm-util.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@itaisteinherz
Copy link
Collaborator Author

@sindresorhus Fixed 👌🏻

@sindresorhus sindresorhus changed the title Verify installed yarn version is >=1.7.0 Verify installed Yarn version is >=1.7.0 Mar 16, 2019
@sindresorhus sindresorhus merged commit 537aa8e into sindresorhus:master Mar 16, 2019
@itaisteinherz itaisteinherz deleted the check-yarn-version branch March 16, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@aladdin-add aladdin-add aladdin-add approved these changes

@SamVerschueren SamVerschueren Awaiting requested review from SamVerschueren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itaisteinherz @sindresorhus @aladdin-add