Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop question Will bump from X to Y. Continue? #377

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Drop question Will bump from X to Y. Continue? #377

merged 1 commit into from
Mar 23, 2019

Conversation

fregante
Copy link
Collaborator

Closes #376

@itaisteinherz
Copy link
Collaborator

itaisteinherz commented Apr 5, 2019

I didn't notice it at first, but this introduced an issue where np always exits after ui.js finishes running because it doesn't return an answer for confirm:

if (!options.confirm) {

The above always returns true because options.confirm isn't defined, which tells np to exit. I'm going to open a PR that fixes this in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants