Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple version bumps when publishing using Yarn #389

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Fix multiple version bumps when publishing using Yarn #389

merged 2 commits into from
Apr 18, 2019

Conversation

itaisteinherz
Copy link
Collaborator

Fixes #387

// cc @edsrzf @minosss

@sindresorhus sindresorhus changed the title Fix multiple version bumps when publishing using yarn Fix multiple version bumps when publishing using Yarn Apr 18, 2019
@sindresorhus
Copy link
Owner

Can you explain the fix?

@itaisteinherz
Copy link
Collaborator Author

itaisteinherz commented Apr 18, 2019

@sindresorhus Running yarn publish --new-version [increment] bumps the package's version several times in addition to the bump that already occurs in the Bump version using ... task. This is what causes the issue described in #387 (at least when testing locally).

@sindresorhus
Copy link
Owner

I don't use Yarn, so I don't know how it works, but if you've tested it locally, that's good enough for me.

@sindresorhus
Copy link
Owner

// @ianwalter I think this issue was introduced in add1387

@sindresorhus sindresorhus merged commit 3601af5 into sindresorhus:master Apr 18, 2019
@itaisteinherz itaisteinherz deleted the fix-multiple-version-bumps branch April 18, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version gets bumped too many times during release
2 participants