Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip deleting node_modules if yarn.lock exists #392

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Skip deleting node_modules if yarn.lock exists #392

merged 2 commits into from
Apr 22, 2019

Conversation

JCMais
Copy link
Contributor

@JCMais JCMais commented Apr 20, 2019

No description provided.

itaisteinherz
itaisteinherz reviewed Apr 20, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
@itaisteinherz itaisteinherz changed the title add yarn.lock check for skipping node_modules removal Skip deleting node_modules in case yarn.lock exists Apr 20, 2019
@itaisteinherz @JCMais
change lock file based on options.yarn value
39dfd83 
Co-Authored-By: JCMais <me@jonathancardoso.com>
@itaisteinherz
Copy link
Collaborator

itaisteinherz commented Apr 22, 2019 •
edited

Thanks @JCMais! ✨

Note: when implementing #384, this should be tested as well.

@itaisteinherz itaisteinherz changed the title Skip deleting node_modules in case yarn.lock exists Skip deleting node_modules if yarn.lock exists Apr 22, 2019
@itaisteinherz itaisteinherz merged commit 5acfb70 into sindresorhus:master Apr 22, 2019
@itaisteinherz itaisteinherz mentioned this pull request Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaisteinherz itaisteinherz itaisteinherz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JCMais @itaisteinherz