Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid skipping push if branch name isn't "master" #397

Merged
merged 2 commits into from
May 9, 2019
Merged

Avoid skipping push if branch name isn't "master" #397

merged 2 commits into from
May 9, 2019

Conversation

itaisteinherz
Copy link
Collaborator

Fixes sequelize/sequelize-typescript#602 (comment)

// cc @RobinBuschmann Let me know if this fixes the issue for you.

@RobinBuschmann
Copy link

@itaisteinherz It works! 👍 Thank you very much.

It only doesn't open a release draft. Do I miss something? The repo url is set in the package.json: https://github.com/RobinBuschmann/sequelize-typescript/blob/1.0.0/package.json#L14

@itaisteinherz
Copy link
Collaborator Author

Weird, I don't see anything suspicious at the moment, though the issue is probably unrelated to this PR. I'll investigate further later today.

@itaisteinherz
Copy link
Collaborator Author

I'm going to merge this as it seems to fix the issue at hand.
@RobinBuschmann It would be great if you could open an issue for the problem you're currently experiencing, and I'll try to take another look at that in a few days.

@itaisteinherz itaisteinherz merged commit 15176f4 into sindresorhus:master May 9, 2019
@itaisteinherz itaisteinherz deleted the fix-upstream-not-master-skip branch May 9, 2019 18:47
@RobinBuschmann
Copy link

Done #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Automated Changelog
2 participants