Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests option #423

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Add tests option #423

merged 1 commit into from
Jun 29, 2019

Conversation

chrisblossom
Copy link
Contributor

@chrisblossom chrisblossom commented May 29, 2019 •
edited by itaisteinherz

I would like to be able to disable running npm test but keep cleanup enabled because I have a custom testing script inside prepublishOnly.

Similar to #299, I have tests running twice (possibly three times with git hooks as well).

Fixes #428

@itaisteinherz
Copy link
Collaborator

Why not set the test npm script to be $ npm run prepublishOnly (or just set it to be the script in prepublishOnly)?

@chrisblossom
Copy link
Contributor Author

That is not possible with my use-case.

Also, I think the yolo option should be removed and replaced with this option + no-cleanup option.

@sindresorhus sindresorhus changed the title add option "tests" Add tests option Jun 29, 2019
@sindresorhus sindresorhus merged commit bea57db into sindresorhus:master Jun 29, 2019
@chrisblossom chrisblossom deleted the option-tests branch July 8, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to skip tests (not cleanup)
3 participants
@chrisblossom @itaisteinherz @sindresorhus