Avoid enabling 2FA for packages published to external registries #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External registry don't all support two-factor authentication. For example, when using [Nexus as npm registry](https://blog.sonatype.com/using-nexus-3-as-your-repository-part-2-npm-packages), the command ```bash > npm profile enable-2fa ``` fails with ``` npm ERR! code E400 npm ERR! 400 Bad Request - POST http://nexus.../content/groups/npm-all/-/npm/v1/tokens npm ERR! A complete log of this run can be found in: npm ERR! ...npm/_logs/2019-06-20T09_24_05_833Z-debug.log ``` This change disables the two-factor authentication task for external registry so that we can continue to publish packages on Nexus.
|
I wonder if any private registries support 2FA other than npm? If so, maybe it's be worth it to add some logic to check? |
itaisteinherz
changed the title
itaisteinherz
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Looks good to me as a temporary solution to the issue, however I'd like to see what @sindresorhus has to say about this before merging the PR.
SamVerschueren
requested changes
Jun 28, 2019
|
Can you mention in small text under |
ianwalter
pushed a commit
to ianwalter/np
that referenced
this pull request
Jul 11, 2019
done in e263ff6 |
Fix styling.
|
Thanks @oligot! |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External registry don't all support two-factor authentication.
For example, when using Nexus as npm registry, the command
> npm profile enable-2fafails with
This change disables the two-factor authentication task for external registry so that we can continue to publish packages on Nexus.