Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct version when creating release draft #435

Merged
merged 4 commits into from
Jun 24, 2019
Merged

Use correct version when creating release draft #435

merged 4 commits into from
Jun 24, 2019

Conversation

yaodingyd
Copy link
Contributor

Fix #434.

The bug is because it uses options.version if it's set in CLI. Adding a transformation in helper function to ensure it's always a semver.

Additionally use the new-github-release-url since v1.0.0 supports node 10.

@itaisteinherz itaisteinherz changed the title fix release draft uses wrong tag Use correct version when creating release draft Jun 23, 2019
@itaisteinherz
Copy link
Collaborator

Additionally use the new-github-release-url since v1.0.0 supports node 10.

We can't do that yet, as the minimum version of Node.js np requires is still v8.

@itaisteinherz
Copy link
Collaborator

@sholladay Can you test this out and see if it fixes the issue for you?
Also @yaodingyd if you'd like to add some tests for this, that would be awesome 😉

@yaodingyd
Copy link
Contributor Author

I would love to but this helper is mostly a pass-through and its important logic(version, prefix and releaseUrl) are almost tested somewhere else.

Copy link
Collaborator

@itaisteinherz itaisteinherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌🏻

@itaisteinherz itaisteinherz merged commit ff5e21a into sindresorhus:master Jun 24, 2019
@sholladay
Copy link
Contributor

Are there any blockers for publishing a new version of np with this fix? Asking because this bug bit me again today. Lots of good stuff in master that's yet to be released! Happy to help if I can. :)

// cc @sindresorhus

@sindresorhus
Copy link
Owner

Done: https://github.com/sindresorhus/np/releases/tag/v5.1.0

Thanks for the reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release draft uses wrong tag
4 participants