Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stopOnError option #16

Merged
merged 5 commits into from Jul 13, 2019
Merged

Add stopOnError option #16

merged 5 commits into from Jul 13, 2019

Conversation

yaodingyd
Copy link
Contributor

Follow this comment: sindresorhus/npm-name#29 (comment)

sindresorhus
sindresorhus requested changes Jun 12, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflicts?

@sindresorhus
Copy link
Owner

sindresorhus commented Jul 1, 2019 •
edited

I think aggregateErrosWhenDone is most explicit.

That name is not correct. It doesn't aggregate the error when it's done. It aggregates the error while iterating and returns an aggregate error when done.

Let's go with stopOnError. I couldn't come up with something better. It should be true by default to preserve existing behavior.

@sindresorhus sindresorhus changed the title add aggregate error option Add stopOnError option Jul 13, 2019
@sindresorhus sindresorhus merged commit 9f0b32f into sindresorhus:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaodingyd @sindresorhus