New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not depend on events? #55
Comments
Nor does it work on React Native any more |
@sindresorhus Can we use this: https://github.com/primus/eventemitter3 or something instead? |
I think Webpack shims the |
React Native uses Metro, not Webpack. And why would we need to shim a package to make an easy module like this to be platform independent? I think the best solution is to have your own event-emitter included if you want to use one in the package and not have dependencies for simple stuff like this. But that's my opinion. |
@olofd I would usually disagree, as my main target is Node.js. Bundlers enable support for browsers, etc. But I'm willing to make an exception here as this module is fairly popular for React Native and browser usage. PR welcome to use https://github.com/primus/eventemitter3 and update to docs to reflect that fact. |
|
* see sindresorhus/p-queue#55 * "find-in-page" widget is built with "electron-renderer" webpack's target and so webpack won't ship the "events" shim automatically since "events" module is marked as external based on the target
Opened #58 to address this by replacing |
* see sindresorhus/p-queue#55 * "find-in-page" widget is built with "electron-renderer" webpack's target and so webpack won't ship the "events" shim automatically since "events" module is marked as external based on the target
In 3.1.0 the dependency of EE => events was introduced. That means this library does no longer work on the web.
The text was updated successfully, but these errors were encountered: