Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the script option for pageres-cli #411

Open
honzajavorek opened this issue Apr 26, 2021 · 2 comments
Open

Support for the script option for pageres-cli #411

honzajavorek opened this issue Apr 26, 2021 · 2 comments

Comments

@honzajavorek
Copy link

Hi, I'm happy with using pageres-cli for most of the screenshots I need, but for a small fraction I'd like to add a script to scrape the screen properly. The pageres library has the script option, but pageres-cli doesn't (or at least it isn't documented). I'd be willing to work on a PR to add this option. Would you accept such change?

My idea would be only to support loading the script from a file, I don't think supporting JS passed in a string is very convenient for a CLI.

@sindresorhus
Copy link
Owner

I think I just forgot to add it to the CLI.

For now, you could use https://github.com/sindresorhus/capture-website-cli instead, which does have such a flag.

This flag should work the same as in capture-website-cli.

@honzajavorek
Copy link
Author

Oh, nice. What is the main difference between capture-website-cli and pageres-cli? The READMEs link each other, but only with words that it's a different take, which doesn't explain much whether it uses a different technology, improves CLI, or one deprecates the other for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants