Remove non-ASCII limitation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sindresorhus#19 I have been unable to find documentation for the non-ASCII limitation, and anecdotal testing have shown forward slashes to be supported in non-ASCII paths. See sindresorhus#19 for more information
|
Makes sense. I cannot find any references to it anymore either. |
birjj
added a commit
to birjj/docusaurus
that referenced
this pull request
Sep 27, 2022
See sindresorhus/slash#19 for discussion on limitation in the originating package This updates the integrated function to match sindresorhus/slash after sindresorhus/slash#20
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19 (see that issue for more information)
I have been unable to find documentation for the non-ASCII limitation, and anecdotal testing has shown forward slashes to be supported in non-ASCII paths:
This limitation has further caused issues in projects that rely on this, e.g. facebook/docusaurus#8124, gatsbyjs/gatsby#19600, and SAP/ui5-tooling#469, amongst others.