Replace: Fix the all option (#416)

sindresorhus · Jul 3, 2022 · 1483de3 · 1483de3
1 parent de5e7fc
commit 1483de3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/source/replace.d.ts b/source/replace.d.ts
@@ -62,6 +62,6 @@ export type Replace<
 	Options extends ReplaceOptions = {},
 > = Input extends `${infer Head}${Search}${infer Tail}`
 	? Options['all'] extends true
-		? Replace<`${Head}${Replacement}${Tail}`, Search, Replacement, Options>
+		? `${Head}${Replacement}${Replace<Tail, Search, Replacement, Options>}`
 		: `${Head}${Replacement}${Tail}`
 	: Input;
diff --git a/test-d/replace.ts b/test-d/replace.ts
@@ -26,3 +26,4 @@ expectType<'hello ❓?'>(replace('hello ??', '?', '❓'));
 expectType<'10-42-00'>(replaceAll('10:42:00', ':', '-'));
 expectType<'userName'>(replaceAll('__userName__', '__', ''));
 expectType<'MyCoolTitle'>(replaceAll('My Cool Title', ' ', ''));
+expectType<'fobarfobar'>(replaceAll('foobarfoobar', 'ob', 'b'));