Add Element to type BuiltIns (#745)

sindresorhus · Nov 11, 2023 · d42ea80 · d42ea80
1 parent 570e27f
commit d42ea80
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/source/internal.d.ts b/source/internal.d.ts
@@ -67,9 +67,9 @@ export type Subtract<A extends number, B extends number> = BuildTuple<A> extends
 	: never;
 
 /**
-Matches any primitive, `Date`, or `RegExp` value.
+Matches any primitive, `Date`, `RegExp`, `Element` value.
 */
-export type BuiltIns = Primitive | Date | RegExp;
+export type BuiltIns = Primitive | Date | RegExp | Element;
 
 export type UpperCaseCharacters = 'A' | 'B' | 'C' | 'D' | 'E' | 'F' | 'G' | 'H' | 'I' | 'J' | 'K' | 'L' | 'M' | 'N' | 'O' | 'P' | 'Q' | 'R' | 'S' | 'T' | 'U' | 'V' | 'W' | 'X' | 'Y' | 'Z';
 

diff --git a/test-d/partial-deep.ts b/test-d/partial-deep.ts
@@ -10,6 +10,7 @@ const foo = {
 	bar: {
 		function: (_: string): void => undefined,
 		classConstructor: ClassA,
+		element: document.createElement('div'),
 		object: {key: 'value'},
 		string: 'waldo',
 		number: 1,
@@ -41,6 +42,7 @@ const instance = new partialDeepFoo.bar!.classConstructor!();
 instance.foo = 2;
 const b = partialDeepFoo.bar!.constructor;
 expectType<((_: string) => void) | undefined>(partialDeepFoo.bar!.function);
+expectType<HTMLDivElement | undefined>(partialDeepFoo.bar!.element);
 expectAssignable<object | undefined>(partialDeepFoo.bar!.object);
 expectType<string | undefined>(partialDeepFoo.bar!.string);
 expectType<number | undefined>(partialDeepFoo.bar!.number);
@@ -100,3 +102,14 @@ expectAssignable<ReadonlyMap<string | undefined, string | undefined> | undefined
 expectAssignable<ReadonlySet<string | undefined> | undefined>(partialDeepNoRecurseIntoArraysBar.readonlySet);
 expectType<readonly string[] | undefined>(partialDeepNoRecurseIntoArraysBar.readonlyArray);
 expectType<readonly ['foo'] | undefined>(partialDeepNoRecurseIntoArraysBar.readonlyTuple);
+
+// Test for interface
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
+interface InterfaceType {
+	string: string;
+	object: {
+		number: number;
+	};
+}
+declare const interfaceType: PartialDeep<InterfaceType>;
+expectType<{string?: string; object?: {number?: number}}>(interfaceType);