Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm targeting Node.js 12.x, which means that I shouldn't be able to compile e.g.
"foo".replaceAll("a", "b")
. But if I import anything from type-fest, from anywhere in my code, then suddenly that code compiles across my entire code base. This is a well-known issue, see e.g. microsoft/TypeScript#33901The culprit was introduced in #37.
As a partial solution, I would recommend replacing the reference to
esnext
with a reference toes2020.bigint
. Perhaps it would also be worth adding a caveat to the README to the effect that this library is only fully compatible with environments that supportes2020.bigint
.